[webkit-reviews] review granted: [Bug 44937] Part 2: Unfork Chromium's FontPlatformDataMac.mm : [Attachment 66027] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 31 15:41:44 PDT 2010


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Jeremy Moskovich
<playmobil at google.com>'s request for review:
Bug 44937: Part 2: Unfork Chromium's FontPlatformDataMac.mm
https://bugs.webkit.org/show_bug.cgi?id=44937

Attachment 66027: Patch
https://bugs.webkit.org/attachment.cgi?id=66027&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
looks good. I wonder if we can somehow create a FontLoadingManager abstraction
that allows having two different implementations of the same declaration? This
would allow us to avoid ifdefs altogether. Not sure how at first glance,
though.


More information about the webkit-reviews mailing list