[webkit-reviews] review granted: [Bug 44951] [GStreamer] can't play m4v videos : [Attachment 66056] proposed patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 44951: [GStreamer] can't play m4v videos
https://bugs.webkit.org/show_bug.cgi?id=44951

Attachment 66056: proposed patch
https://bugs.webkit.org/attachment.cgi?id=66056&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>

> +	   * media/media-can-play-mpeg-video-expected.txt: Added.
> +	   * media/media-can-play-mpeg-video.html: Added.
The test name should probably change because it is testing for MPEG-4 support
and "mpeg" can mean MPEG-1.


> +	   <p>Test HTMLMediaElement <em>canPlayType()</em> method with
> +	   multiple video mpeg MIME types.</p>
> +
This is incorrect because you you only test for "video/x-m4v", but you might as
well add a test for the standard type as well.

r=me with these minor changes.