[webkit-reviews] review denied: [Bug 44926] Multiple accelerated 2D canvases should be able to use the same GraphicsContext3D : [Attachment 66074] compile fix for gtk/win/mac

[bugzilla-daemon at webkit.org]

Chris Marrin <cmarrin at apple.com> has denied James Robinson
<jamesr at chromium.org>'s request for review:
Bug 44926: Multiple accelerated 2D canvases should be able to use the same
GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=44926

Attachment 66074: compile fix for gtk/win/mac
https://bugs.webkit.org/attachment.cgi?id=66074&action=review

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
> WebCore/platform/graphics/gpu/CanvasFramebuffer.cpp:67
> +    m_context->copyTextureToCompositor(m_offscreenColorTexture,
m_offscreenParentColorTexture);

This model is wrong for EAGL (iOS). There, the model is that you are handing
the FBO object to the PlatformLayer. The object you're passing is actually a
RenderBuffer not a Texture, but it is still represented by an OpenGL Object
handle. The model should change to hide the m_offscreenParentColorTexture in
the PlatformLayer and have this call pass m_offscreenColorBuffer (renamed for
clarity) and PlatformLayer.