[webkit-reviews] review denied: [Bug 44734] Add LocalFileSystem.requestFileSystem interface to DOMWindow : [Attachment 65846] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 44734: Add LocalFileSystem.requestFileSystem interface to DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=44734

Attachment 65846: Patch
https://bugs.webkit.org/attachment.cgi?id=65846&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
> WebCore/bindings/generic/RuntimeEnabledFeatures.h:141
> +    static bool requestFileSystemEnabled() { return isFileSystemEnabled; }
Why do we need requestFileSystemEnabled? What's the difference between
fileSystemEnabled and requestFileSystemEnabled?

> WebCore/page/DOMWindow.h:83
> +#if ENABLE(FILE_SYSTEM)
Normally we do not need to guard this.

> WebCore/page/DOMWindow.h:86
> +    class ErrorCallback;
Please sort these.

> WebCore/page/Settings.h:244
> +	   const String& fileSystemRootPath() const { return
m_fileSystemRootPath; }
Do you need to guard these?

> WebKit/chromium/ChangeLog:15
> +2010-08-27  Kinuko Yasuda  <kinuko at chromium.org>
Why do you produce 2 ChangeLog entries?