[webkit-reviews] review granted: [Bug 44972] Expose WorkerContext.createBlobURL and WorkerContext.revokeBlobURL : [Attachment 66087] Proposed Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 44972: Expose WorkerContext.createBlobURL and WorkerContext.revokeBlobURL
https://bugs.webkit.org/show_bug.cgi?id=44972

Attachment 66087: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=66087&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> diff --git a/WebCore/page/SecurityOrigin.cpp
b/WebCore/page/SecurityOrigin.cpp
> +#if ENABLE(BLOB)
> +    // For blob scheme, we want to ignore this check.
> +    if (!url.protocolIs("blob"))
> +	   if (targetOrigin->isUnique())
> +	       return false;
> +#else
>      if (targetOrigin->isUnique())
>	   return false;
> +#endif


Please consider:

bool doUniqueOriginCheck = true;
#if ENABLE(BLOB)
    // For blob scheme, we want to ignore this check.
    doUniqueOriginCheck = !url.protocolIs("blob"));
#endif
    if (doUniqueOriginCheck && targetOrigin->isUnique())
	return false;