[webkit-reviews] review denied: [Bug 40934] Support <script defer> as specified by HTML5 : [Attachment 66066] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 31 12:01:42 PDT 2010
Eric Seidel <eric at webkit.org> has denied Tony Gentilcore <tonyg at chromium.org>'s
request for review:
Bug 40934: Support <script defer> as specified by HTML5
https://bugs.webkit.org/show_bug.cgi?id=40934
Attachment 66066: Patch
https://bugs.webkit.org/attachment.cgi?id=66066&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
> WebCore/html/parser/HTMLDocumentParser.cpp:346
> + stop();
I'm not sure stop() is the right name here. Since it doesn't set
m_parserStopped.
> WebCore/html/parser/HTMLDocumentParser.h:137
> + bool m_active; //
http://www.whatwg.org/specs/web-apps/current-work/#active-parser
Why not just use m_parserStopped?
More information about the webkit-reviews
mailing list