[webkit-reviews] review granted: [Bug 44782] [GTK] ScrollbarThemeGtk should respond to theme changes : [Attachment 65746] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 44782: [GTK] ScrollbarThemeGtk should respond to theme changes
https://bugs.webkit.org/show_bug.cgi?id=44782

Attachment 65746: Patch
https://bugs.webkit.org/attachment.cgi?id=65746&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
 89	// If the theme changed, update the thickness of every scrollbar
widget.
 90	// The platform-independent scrollbar code isn't yet smart enough to
 91	// get this information when it paints.
 92	HashSet<Scrollbar*>::iterator end = gScrollbars->end();
 93	for (HashSet<Scrollbar*>::iterator it = gScrollbars->begin(); it !=
end; ++it) {
 94	    Scrollbar* scrollbar = (*it);

Saying 'If the theme changed' seems to imply that we're depending on a
conditional, but if we're in this function it's because the theme has changed,
so I'd suggest only stating what is being done. Looks good otherwise!