[webkit-reviews] review granted: [Bug 44962] deduplicate code from Node::checkReplaceChild and Node::checkAddChild : [Attachment 66069] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 44962: deduplicate code from Node::checkReplaceChild and
Node::checkAddChild
https://bugs.webkit.org/show_bug.cgi?id=44962

Attachment 66069: Patch
https://bugs.webkit.org/attachment.cgi?id=66069&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
> diff --git a/WebCore/dom/Node.cpp b/WebCore/dom/Node.cpp
> -bool Node::canReplaceChild(Node* newChild, Node*)
> +static bool isChildTypeAllowed(Node* parent, Node* child)

Nit: Perhaps newParent or newChild to make it clear that child->parent() !=
parent?

The side by side diff was much easier to read.