[webkit-reviews] review granted: [Bug 44875] Web Inspector: it'd be better to introduce inspector API related tests. : [Attachment 65950] [patch] third iteration.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 31 09:49:59 PDT 2010


Joseph Pecoraro <joepeck at webkit.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 44875: Web Inspector: it'd be better to introduce inspector API related
tests.
https://bugs.webkit.org/show_bug.cgi?id=44875

Attachment 65950: [patch] third iteration.
https://bugs.webkit.org/attachment.cgi?id=65950&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
> ... you could look at JavaScript syntax errors and if they print out with a
period.

JavaScript errors don't. So maybe these shouldn't. Thoughts?


> Patch looks much better. I will take a closer look tomorrow.

r=me addressing the comments I had above. Please file a follow-up, if there
isn't one already, for testing sendMessageToBackend message parsing and
dispatching.


More information about the webkit-reviews mailing list