[webkit-reviews] review granted: [Bug 44947] Web Inspector: The parser of Inspector protocol messages should be covered by a test. : [Attachment 66050] [patch] initial version. Just missed the test.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 31 07:47:32 PDT 2010
Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 44947: Web Inspector: The parser of Inspector protocol messages should be
covered by a test.
https://bugs.webkit.org/show_bug.cgi?id=44947
Attachment 66050: [patch] initial version. Just missed the test.
https://bugs.webkit.org/attachment.cgi?id=66050&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
> LayoutTests/inspector/report-protocol-errors.html:34
> + for (var message in messages)
Usually we don't use for/in for iterating over array elements.
More information about the webkit-reviews
mailing list