[webkit-reviews] review requested: [Bug 44863] Renderer ASSERT failure in Chrome when using click-to-play : [Attachment 66043] Always run pending style recalcs when layouting.

[bugzilla-daemon at webkit.org]

Bernhard Bauer <bauerb at chromium.org> has asked	for review:
Bug 44863: Renderer ASSERT failure in Chrome when using click-to-play
https://bugs.webkit.org/show_bug.cgi?id=44863

Attachment 66043: Always run pending style recalcs when layouting.
https://bugs.webkit.org/attachment.cgi?id=66043&action=review

------- Additional Comments from Bernhard Bauer <bauerb at chromium.org>
It seems this is caused by a pending style recalculation when FrameView::layout
is called. 

If a style recalc is pending, Document::updateStyleIfNeeded is called from
m_frame->selection()->updateAppearance() in FrameView.cpp:784, which is after
the layout has happened, so it sets the layout flag again.

My solution is to call updateStyleIfNeeded before layouting, which can
conveniently done by moving it out of the else clause around FrameView.cpp:657.