[webkit-reviews] review canceled: [Bug 41364] [Qt] QWebPage::allowGeolocationRequest should be async API : [Attachment 64757] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 31 06:17:58 PDT 2010


Mahesh Kulkarni <mahesh.kulkarni at nokia.com> has canceled Mahesh Kulkarni
<mahesh.kulkarni at nokia.com>'s request for review:
Bug 41364: [Qt] QWebPage::allowGeolocationRequest should be async API
https://bugs.webkit.org/show_bug.cgi?id=41364

Attachment 64757: patch
https://bugs.webkit.org/attachment.cgi?id=64757&action=review

------- Additional Comments from Mahesh Kulkarni <mahesh.kulkarni at nokia.com>
Removed : cache client permission from call QWebPage::setUserPermission() even
without any geolocation requests. When Webcore makes a geolocation permission
request, cached permission will be passed on. This way clients can set default
sync permission to geolocation. 

Please review


More information about the webkit-reviews mailing list