[webkit-reviews] review canceled: [Bug 44935] [Qt] Web process crash when pressing modifiers in input field : [Attachment 66029] Patch fixing the crash

[bugzilla-daemon at webkit.org]

Ariya Hidayat <ariya.hidayat at gmail.com> has canceled Kimmo Kinnunen
<kimmo.t.kinnunen at nokia.com>'s request for review:
Bug 44935: [Qt] Web process crash when pressing modifiers in input field
https://bugs.webkit.org/show_bug.cgi?id=44935

Attachment 66029: Patch fixing the crash 
https://bugs.webkit.org/attachment.cgi?id=66029&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>
> +#if defined(XP_UNIX)
> +uint32_t PlatformKeyboardEvent::x11NativeModifiers() const
> +{
> +    ASSERT(m_qtEvent);
> +    return m_qtEvent->nativeModifiers();
> +}
> +
> +uint32_t PlatformKeyboardEvent::x11NativeScanCode() const
> +{
> +    ASSERT(m_qtEvent);
> +    return m_qtEvent->nativeScanCode();
> +}
> +#endif

This is confusing. Can you explain what is the reason behind introducing these
two Unix-only functions?