[webkit-reviews] review denied: [Bug 44939] Web Inspector: move debugger tests to the new test harness : [Attachment 66026] Proposed patch.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 44939: Web Inspector: move debugger tests to the new test harness
https://bugs.webkit.org/show_bug.cgi?id=44939

Attachment 66026: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=66026&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
btw, what's the point in switching debugger tests to inspector-tests2.js?

> LayoutTests/http/tests/inspector/inspector-test2.js:164
> +    dumpedResultsCount = results.length;
Please keep this counter on the front-end(or even get rid of it completely) and
slice results array before passing it here.

> LayoutTests/inspector/debugger-cyclic-ref-expected.txt:4
> -Set timer for test function.
Why is this gone?

> LayoutTests/inspector/debugger-cyclic-ref.html:13
> -    notifyDone();
This should be called after we left debugger code, you cannot simply invoke
this code from the front-end(see the change that introduced this line). r- for
that.

> LayoutTests/inspector/debugger-eval-while-paused.html:12
> -    notifyDone();
This should be reverted.

> LayoutTests/inspector/debugger-no-nested-pause.html:11
> -    if (testFunction.didExitFromNestedCall)
Now the test will pass even if testFunction is executed only once.