[webkit-reviews] review granted: [Bug 44518] Web Inspector: add audits support to extension API : [Attachment 66022] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 31 04:43:45 PDT 2010
Yury Semikhatsky <yurys at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 44518: Web Inspector: add audits support to extension API
https://bugs.webkit.org/show_bug.cgi?id=44518
Attachment 66022: patch
https://bugs.webkit.org/attachment.cgi?id=66022&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
> LayoutTests/inspector/extensions-audits-tests.js:39
> +test = function()
var test =
> LayoutTests/inspector/extensions-audits.html:14
> + log("category.onAuditStarted fired");
Why is it not just output?
> LayoutTests/inspector/extensions-test.js:11
> + if (/^extension_/.exec(symbol) && typeof window[symbol] ===
"function")
Should be test() since you don't use result array.
More information about the webkit-reviews
mailing list