[webkit-reviews] review denied: [Bug 44915] Need to handle CSSValueAuto in CSSPrimitiveValue::operator ETextAlign() : [Attachment 65994] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Justin Garcia
<justin.garcia at apple.com>'s request for review:
Bug 44915: Need to handle CSSValueAuto in CSSPrimitiveValue::operator
ETextAlign()
https://bugs.webkit.org/show_bug.cgi?id=44915

Attachment 65994: patch
https://bugs.webkit.org/attachment.cgi?id=65994&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   No new tests because we don't appear to cast a CSSPrimitiveValue to
an ETextAlign anywhere currently.

We convert a CSSPrimitiveValue to an ETextAlign in
CSSStyleSelector::applyProperty's case for CSSPropertyTextAlign. You should be
able to create a test case based on using text-align: auto.

> Index: WebCore.xcodeproj/project.pbxproj
> ===================================================================
> --- WebCore.xcodeproj/project.pbxproj (revision 66441)
> +++ WebCore.xcodeproj/project.pbxproj (working copy)
> @@ -20491,6 +20491,7 @@
>			isa = PBXProject;
>			buildConfigurationList = 149C284308902B11008A9EFC /*
Build configuration list for PBXProject "WebCore" */;
>			compatibilityVersion = "Xcode 2.4";
> +			developmentRegion = English;
>			hasScannedForEncodings = 1;
>			knownRegions = (
>				English,

Please do not check this project change in.

review- for lack of test case