[webkit-reviews] review granted: [Bug 44925] Move FileSystem related files from WebCore/storage to WebCore/fileapi. : [Attachment 66007] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 44925: Move FileSystem related files from WebCore/storage to
WebCore/fileapi.
https://bugs.webkit.org/show_bug.cgi?id=44925

Attachment 66007: Patch
https://bugs.webkit.org/attachment.cgi?id=66007&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
> WebCore/CMakeLists.txt:1593
> +if (ENABLE_FILE_SYSTEM)
> +    LIST(APPEND WebCore_SOURCES
> +	   fileapi/DirectoryEntry.cpp
> +	   fileapi/DirectoryReader.cpp
> +	   fileapi/DOMFilePath.cpp
> +	   fileapi/DOMFileSystem.cpp
> +	   fileapi/Entry.cpp
> +	   fileapi/EntryArray.cpp
> +	   fileapi/FileEntry.cpp
> +	   fileapi/FileSystemCallbacks.cpp
> +	   fileapi/LocalFileSystem.cpp
> +	   platform/AsyncFileSystem.cpp
> +    )
> +ENDIF ()
These weren't conditional before.  Also, what about the existing files in
fileapi?  Should those be conditional too?

> WebCore/GNUmakefile.am:3052
> +	  WebCore/fileapi/DirectoryEntry.cpp \
> +	  WebCore/fileapi/DirectoryEntry.h \
> +	  WebCore/fileapi/DirectoryReader.cpp \
> +	  WebCore/fileapi/DirectoryReader.h \
> +	  WebCore/fileapi/DOMFilePath.cpp \
> +	  WebCore/fileapi/DOMFilePath.h \
> +	  WebCore/fileapi/DOMFileSystem.cpp \
> +	  WebCore/fileapi/DOMFileSystem.h \
> +	  WebCore/fileapi/EntriesCallback.h \
> +	  WebCore/fileapi/Entry.cpp \
> +	  WebCore/fileapi/Entry.h \
> +	  WebCore/fileapi/EntryArray.cpp \
> +	  WebCore/fileapi/EntryArray.h \
> +	  WebCore/fileapi/EntryCallback.h \
> +	  WebCore/fileapi/ErrorCallback.h \
> +	  WebCore/fileapi/FileEntry.cpp \
> +	  WebCore/fileapi/FileEntry.h \
> +	  WebCore/fileapi/FileSystemCallback.h \
> +	  WebCore/fileapi/FileSystemCallbacks.cpp \
> +	  WebCore/fileapi/FileSystemCallbacks.h \
> +	  WebCore/fileapi/Flags.h \
> +	  WebCore/fileapi/LocalFileSystem.cpp \
> +	  WebCore/fileapi/LocalFileSystem.h \
> +	  WebCore/fileapi/Metadata.h \
> +	  WebCore/fileapi/MetadataCallback.h
Should these be textually next to the other fileapi files?