[webkit-reviews] review granted: [Bug 44914] [chromium] Add an interface for platform copy/paste drag/drop data objects : [Attachment 65985] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 44914: [chromium] Add an interface for platform copy/paste drag/drop data
objects
https://bugs.webkit.org/show_bug.cgi?id=44914

Attachment 65985: Patch
https://bugs.webkit.org/attachment.cgi?id=65985&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +	   [chromium] Add an interface for platform copy/paste drag/drop data
objects
> +	   https://bugs.webkit.org/show_bug.cgi?id=44914

Nit: Please add a sentence explaining the general goal (ie., something about so
we can eventually support arbitrary data types).

> diff --git a/WebCore/platform/chromium/ChromiumDataObjectNew.h
b/WebCore/platform/chromium/ChromiumDataObjectNew.h
> +    virtual String getData(const String& type, bool& succeeded) const = 0;
> +    virtual bool setData(const String& type, const String& data) = 0;

It seems like these methods should use the same style.	Two possibilities: both
return a bool (on success) or just remove the bool param complete from getdata
(do we need to differentiate between empty and fail?).	The other getters below
don't seem to use a bool.