[webkit-reviews] review granted: [Bug 44865] REGRESSION (r66156): Sites using AppleConnect for authentication fail to log in. : [Attachment 65980] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 30 17:40:01 PDT 2010
Darin Adler <darin at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 44865: REGRESSION (r66156): Sites using AppleConnect for authentication
fail to log in.
https://bugs.webkit.org/show_bug.cgi?id=44865
Attachment 65980: Patch
https://bugs.webkit.org/attachment.cgi?id=65980&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> + if (frame && frame->settings()->needsSiteSpecificQuirks() && mimeType ==
"application/x-snkp") {
Since MIME types are not case sensitive it would be better to use
equalIgnoringCase.
You’ll also need to update StringsNotToBeLocalized.txt to add this new
non-localized string.
More information about the webkit-reviews
mailing list