[webkit-reviews] review canceled: [Bug 44907] Refactor input[type=range] to use a more natural shadow DOM model. : [Attachment 65974] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 30 16:05:25 PDT 2010


Dimitri Glazkov (Google) <dglazkov at chromium.org> has canceled Dimitri Glazkov
(Google) <dglazkov at chromium.org>'s request for review:
Bug 44907: Refactor input[type=range] to use a more natural shadow DOM model.
https://bugs.webkit.org/show_bug.cgi?id=44907

Attachment 65974: Patch
https://bugs.webkit.org/attachment.cgi?id=65974&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
This is work in progress, not yet ready for review.

I looked at the way we hang a DOM node off of RenderObjects for our shadow DOM
implementation, and decided it was evil.

So I started cooking a way to fix this. This (incomplete) patch highlights the
approach: make shadow DOM nodes part of the standard DOM node lifecycle, and
take advantage of the already existing DOM/layout functionality, thus avoiding
things like forwardEvent, updateFromElement, etc.


More information about the webkit-reviews mailing list