[webkit-reviews] review granted: [Bug 44732] Add DOMFileSystem implementation to support Entry manipulation operations : [Attachment 65939] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 30 12:56:48 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 44732: Add DOMFileSystem implementation to support Entry manipulation
operations
https://bugs.webkit.org/show_bug.cgi?id=44732
Attachment 65939: Patch
https://bugs.webkit.org/attachment.cgi?id=65939&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
glad to see that fireImmediates was not necessary afterall.
> :82
> + // FIXME: move this to a more generic place.
nit: can this class be made private?
> :70
> + // FIXME: clean up this.
please make this FIXME comment more descriptive. it is unclear what you want
to clean up.
More information about the webkit-reviews
mailing list