[webkit-reviews] review denied: [Bug 30625] Implement WebGL on Windows : [Attachment 65767] Refactored some non Mac specific OpenGL code out of GraphicsContext3DMac.mm to make ANGLE (libGLESv2) integration easier.

[bugzilla-daemon at webkit.org]

Chris Marrin <cmarrin at apple.com> has denied Paul Sawaya <psawaya at apple.com>'s
request for review:
Bug 30625: Implement WebGL on Windows
https://bugs.webkit.org/show_bug.cgi?id=30625

Attachment 65767: Refactored some non Mac specific OpenGL code out of
GraphicsContext3DMac.mm to make ANGLE (libGLESv2) integration easier.
https://bugs.webkit.org/attachment.cgi?id=65767&action=review

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
It looks like you didn't do an svn copy to create the
GraphicsContext3DOpenGL.cpp file. If you do this:

    svn cp WebCore/platform/graphics/mac/GraphicsContext3DMac.mm
WebCore/platform/graphics/GraphicsContextOpenGL.cpp

then svn will remember where the file came from, which both helps with history
tracking and makes svn diff show the differences between the old and new files.
To avoid having to do any extra work:

1) Move your current GraphicsContext3DOpenGL.cpp to a -saved file
2) do the svn cp
3) delete the copied GraphicsContext3DOpenGL.cpp and replace it with your
-saved version.

I believe that will make everything work and show us a better diff.