[webkit-reviews] review denied: [Bug 44261] [GTK] Add HTTP caching support : [Attachment 65900] Imported SoupURILoader to Webkit. New public API for HTTP cache

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 44261: [GTK] Add HTTP caching support
https://bugs.webkit.org/show_bug.cgi?id=44261

Attachment 65900: Imported SoupURILoader to Webkit. New public API for HTTP
cache
https://bugs.webkit.org/attachment.cgi?id=65900&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
This will still need a changelog entry, and the build breakage implies we need
to either depend on a newer glib or factor this code out if building with an
oldish glib. There's a check in place to decide whether to use GSettings. I'd
recommend adding a check specifically for GVariant, to decide whether to build
this new code or not. I won't bother reviewing the actual code, except for the
public APIs. The identation in soup-cache.c is completely broken (no spaces at
all in various places, 4-space indentation in others), I think you may want to
run indent in all soup cache files to have them match the libsoup style.