[webkit-reviews] review granted: [Bug 44837] Web Inspector: persist DOM breakpoints between page reloads : [Attachment 65902] Proposed patch.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 44837: Web Inspector: persist DOM breakpoints between page reloads
https://bugs.webkit.org/show_bug.cgi?id=44837

Attachment 65902: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=65902&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
> +++ b/LayoutTests/inspector/dom-breakpoints.html
> @@ -35,7 +35,7 @@ var test = function()
>      function step2(node)
>      {
>	   InspectorTest.addResult("Found dom node d0.");
> -	   WebInspector.domBreakpointManager.setBreakpoint(node,
WebInspector.DOMBreakpoint.Types.SubtreeModified);
> +	   node.setBreakpoint("SubtreeModified");
Use constants for such arguments.


> +++ b/WebCore/inspector/front-end/DOMAgent.js
> @@ -143,6 +143,40 @@ WebInspector.DOMNode.prototype = {
>	   this.ownerDocument._domAgent.removeAttributeAsync(this, name,
callback);
>      },
>  
> +    path: function()
> +    {
> +	   var path = [];
> +	   var node = this;
> +	   while (node && "index" in node && node.nodeName &&
node.nodeName.length) {
Is it possible that there is node.index but but no node.nodeName?