[webkit-reviews] review granted: [Bug 44812] [chromium] Move more common settings to webcore_prerequisites : [Attachment 65852] webcore.gyp patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 44812: [chromium] Move more common settings to webcore_prerequisites
https://bugs.webkit.org/show_bug.cgi?id=44812

Attachment 65852: webcore.gyp patch
https://bugs.webkit.org/attachment.cgi?id=65852&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index bfcce4f..2da30fe 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -2,6 +2,14 @@
>  
>	   Reviewed by NOBODY (OOPS!).
>  
> +	   Move more common settings to webcore_prerequisites
> +
> +	   * WebCore.gyp/WebCore.gyp:
> +
> +2010-08-27  Marc-Antoine Ruel  <maruel at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
>	   Rename webcore to 'webcore_remaining'.
>	   Create a meta-target webcore that inherits from every webcore_XXX
targets. (Currently 1)
>	   Move direct_dependent_settings and export_dependent_settings from
webcore_remaining to webcore

Add the bug URL to the ChangeLog entry please.