[webkit-reviews] review granted: [Bug 38354] Support for Percentage Values in border-radius : [Attachment 65066] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 38354: Support for Percentage Values in border-radius
https://bugs.webkit.org/show_bug.cgi?id=38354

Attachment 65066: Patch
https://bugs.webkit.org/attachment.cgi?id=65066&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   const int intMaxForLength = 0x7ffffff; // max value for a 28-bit int

> +	   const int intMinForLength = (-0x7ffffff - 1); // min value for a
28-bit int

OK, but where does "28-bit" come from? I presume from Length. These constants
should be in Length.h, not here inline in the code.

> +    BorderData() : m_topLeft(Length(0, Fixed), Length(0, Fixed)),
m_topRight(Length(0, Fixed), Length(0, Fixed))
> +		    , m_bottomLeft(Length(0, Fixed), Length(0, Fixed)),
m_bottomRight(Length(0, Fixed), Length(0, Fixed)) {}

This is not the correct formatting. Our style guide has a specific format for
this:

    BorderData()
	: m_topLeft(Length(0, Fixed), Length(0, Fixed))
	, m_topRight(Length(0, Fixed), Length(0, Fixed))
	, m_bottomLeft(Length(0, Fixed), Length(0, Fixed))
	, m_bottomRight(Length(0, Fixed), Length(0, Fixed))
    {
    }

r=me, but please consider fixing the two issues above