[webkit-reviews] review granted: [Bug 20677] Webkit wraps between hyphen-minus and numeric characters : [Attachment 63161] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 29 12:39:41 PDT 2010


Darin Adler <darin at apple.com> has granted Xianzhu Wang <phnixwxz at gmail.com>'s
request for review:
Bug 20677: Webkit wraps between hyphen-minus and numeric characters
https://bugs.webkit.org/show_bug.cgi?id=20677

Attachment 63161: patch
https://bugs.webkit.org/attachment.cgi?id=63161&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   Webkit wraps between hyphen–minus and numeric characters

Need to stick to ASCII in the change log.

> +	   Modified the ascii line breaking table to disallow line breaking
> +	   after hyphen-minus before numeric characters.

It's ASCII, not ascii.

> +	   * rendering/break_lines.cpp:
> +	   (WebCore::):

This function name isn't right. Please don't leave garbled things like this in
the change log, even if a script generates them.


More information about the webkit-reviews mailing list