[webkit-reviews] review granted: [Bug 40784] Remove older versions of custom Carbon events in npapi.h : [Attachment 59040] fix v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 29 12:29:00 PDT 2010


Darin Adler <darin at apple.com> has granted Stuart Morgan
<stuartmorgan at chromium.org>'s request for review:
Bug 40784: Remove older versions of custom Carbon events in npapi.h
https://bugs.webkit.org/show_bug.cgi?id=40784

Attachment 59040: fix v1
https://bugs.webkit.org/attachment.cgi?id=59040&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Seems great to fix everything in our own code. But why are we removing these
macros from a public header? Are you sure this is OK? Did Netscape already do
this in their copy of npapi.h?

Setting review+ assuming the answer to all those questions is "a good reason",
yes, and yes.


More information about the webkit-reviews mailing list