[webkit-reviews] review granted: [Bug 44595] DOM Selection: collapse() and selectAllChildren() should throw WRONG_DOCUMENT_ERR if node belongs to other document : [Attachment 65387] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 44595: DOM Selection: collapse() and selectAllChildren() should throw
WRONG_DOCUMENT_ERR if node belongs to other document
https://bugs.webkit.org/show_bug.cgi?id=44595

Attachment 65387: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=65387&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    const Document* selectionDocument = m_frame ? m_frame->document() : 0;
> +    const Document* nodeDocument = node ? node->document() : 0;

The const here does no good.

> +    const Document* selectionDocument = m_frame ? m_frame->document() : 0;

Same here.

I’d like this even better if the regression test covered the null frame and
null node cases. I can't tell if it does.

r=me