[webkit-reviews] review denied: [Bug 42390] Multi-layer backgrounds repaint (in low quality) every 0.5 seconds : [Attachment 61696] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 42390: Multi-layer backgrounds repaint (in low quality) every 0.5 seconds
https://bugs.webkit.org/show_bug.cgi?id=42390

Attachment 61696: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=61696&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This seems more like a workaround than a fix. Just turns off the logic for
layers that have a next pointer, with no comment or indication in the code why,
and no regression test. We can do better.

> -	       bool useLowQualityScaling = shouldPaintAtLowQuality(context,
image, tileSize);
> +	       bool useLowQualityScaling;
> +	       if (bgLayer->next())
> +		   useLowQualityScaling = false;
> +	       else
> +		   useLowQualityScaling = shouldPaintAtLowQuality(context,
image, tileSize);

I think the logic would be easier to read like this:

    bool useLowQualityScaling = !bgLayer->next() &&
shouldPaintAtLowQuality(context, image, tileSize);

But still, we need an explanation for why we should paint multiple layer
backgrounds always in high quality.