[webkit-reviews] review granted: [Bug 29000] Implement HTML5's fakepath : [Attachment 39130] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Aug 29 11:39:04 PDT 2010
Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 29000: Implement HTML5's fakepath
https://bugs.webkit.org/show_bug.cgi?id=29000
Attachment 39130: patch
https://bugs.webkit.org/attachment.cgi?id=39130&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> + if (!m_fileList->isEmpty()) {
> + String value = "C:\\fakepath\\";
> + value.append(m_fileList->item(0)->fileName());
> + return value;
> + }
This can be written just with the plus operator:
if (!m_fileList->isEmpty())
return C:\\fakepath\\" + m_fileList->item(0)->fileName();
I think that's more pleasant.
But also, I think that the fakepath will be mysterious without a comment.
More information about the webkit-reviews
mailing list