[webkit-reviews] review granted: [Bug 44787] [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer are deprecated : [Attachment 65833] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 29 01:29:04 PDT 2010


Martin Robinson <mrobinson at webkit.org> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 44787: [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
are deprecated
https://bugs.webkit.org/show_bug.cgi?id=44787

Attachment 65833: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=65833&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
 1112 Programs_unittests_testcopyandpaste_SOURCES =
WebKit/gtk/tests/testcopyandpaste.c \
 1113					WebCore/platform/gtk/GtkVersioning.c
 1114 Programs_unittests_testcopyandpaste_CFLAGS = $(webkit_tests_cflags) \
 1115					-I$(srcdir)/WebCore/platform/gtk \
 1116					-I$(srcdir)/WebCore

It's hard to tell from the diff, but these lines should only be indented one
tab to match the rest of the file.

Otherwise this looks good. If the bots need a clean build, do you mind cleaning
them after you land? Thanks!


More information about the webkit-reviews mailing list