[webkit-reviews] review granted: [Bug 44831] The logic to escape entities in appendEscapedContent and appendAttributeValue should be merged : [Attachment 65842] fixed per Darin's comment

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 44831: The logic to escape entities in appendEscapedContent and
appendAttributeValue should be merged
https://bugs.webkit.org/show_bug.cgi?id=44831

Attachment 65842: fixed per Darin's comment
https://bugs.webkit.org/attachment.cgi?id=65842&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    EntityMaskInCDATA = EntityNone,
> +    EntityMaskInPCDATA = EntityAmp | EntityLt | EntityGt,
> +    EntityMaskInHTMLPCDATA = EntityMaskInPCDATA | EntityNbsp,
> +    EntityMaskInAttributeValue = EntityAmp | EntityLt | EntityGt |
EntityQuot,
> +    EntityMaskInHTMLAttributeValue = EntityMaskInAttributeValue |
EntityNbsp,

At some point I’d like to see comments on the above explaining why we escape
what we do in each context. Here where we define the constants seems to be the
perfect place.

r=me