[webkit-reviews] review granted: [Bug 44781] HTMLTreeBuilder needs to call HTMLFormElement::setDemoted : [Attachment 65816] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 28 02:35:21 PDT 2010


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 44781: HTMLTreeBuilder needs to call HTMLFormElement::setDemoted
https://bugs.webkit.org/show_bug.cgi?id=44781

Attachment 65816: Patch
https://bugs.webkit.org/attachment.cgi?id=65816&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/html/parser/HTMLConstructionSite.cpp:259
 +	ASSERT(element->tagQName() == formTag);
->hasName(formTag)

WebCore/html/parser/HTMLConstructionSite.cpp:256
 +  void HTMLConstructionSite::insertHTMLFormElement(AtomicHTMLToken& token,
bool isDemoted)
isDemoted isn't very clear.  doNotAttach?  donno.

So wrong.  But better than what we had.


More information about the webkit-reviews mailing list