[webkit-reviews] review denied: [Bug 44803] Decompose computing an element's computed language : [Attachment 65798] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 27 23:17:30 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Ilya Sherman
<isherman at chromium.org>'s request for review:
Bug 44803: Decompose computing an element's computed language
https://bugs.webkit.org/show_bug.cgi?id=44803

Attachment 65798: Patch
https://bugs.webkit.org/attachment.cgi?id=65798&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebElement.h:59
 +	    WEBKIT_API WebString computeInheritedLang() const;
for the API at least, i recommend spelling out Language.  you should also break

this method apart from the others and add a comment describing what it does.
it isn't obvious what this method does.


More information about the webkit-reviews mailing list