[webkit-reviews] review denied: [Bug 44472] Add AX notification for childrenChanged : [Attachment 65793] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 27 20:49:12 PDT 2010
chris fleizach <cfleizach at apple.com> has denied chris.guillory at google.com's
request for review:
Bug 44472: Add AX notification for childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=44472
Attachment 65793: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=65793&action=review
------- Additional Comments from chris fleizach <cfleizach at apple.com>
> Index: WebCore/accessibility/chromium/AXObjectCacheChromium.cpp
> ===================================================================
> --- WebCore/accessibility/chromium/AXObjectCacheChromium.cpp (revision
66033)
> +++ WebCore/accessibility/chromium/AXObjectCacheChromium.cpp (working copy)
> @@ -56,15 +56,23 @@ void AXObjectCache::attachWrapper(Access
>
> void AXObjectCache::postPlatformNotification(AccessibilityObject* obj,
AXNotification notification)
> {
> - if (notification != AXCheckedStateChanged)
> + if (notification != AXCheckedStateChanged && notification !=
AXChildrenChanged)
> return;
>
I don't think you need this check, since you have a switch statement below
More information about the webkit-reviews
mailing list