[webkit-reviews] review granted: [Bug 44810] Add UserContent API to WebKit2 InjectedBundle : [Attachment 65802] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Sam Weinig <sam at webkit.org>'s request for review:
Bug 44810: Add UserContent API to WebKit2 InjectedBundle
https://bugs.webkit.org/show_bug.cgi?id=44810

Attachment 65802: Patch
https://bugs.webkit.org/attachment.cgi?id=65802&action=review

------- Additional Comments from mitz at webkit.org
> +static PassOwnPtr<Vector<String> > toStringVector(ImmutableArray* patterns)
> +{
> +    size_t size =  patterns->size();
> +    if (!size)
> +	   return 0;
> +
> +    Vector<String>* patternsVector = new Vector<String>;

Reserve initial capacity here…

> +    for (size_t i = 0; i < size; ++i) {
> +	   WebString* entry = patterns->at<WebString>(i);
> +	   if (entry)
> +	       patternsVector->append(entry->string());

…unchecked append here.