[webkit-reviews] review canceled: [Bug 42826] Potential crash in thread pool because WorkQueue keeps waiting on closed HANDLEs : [Attachment 65752] Teach WorkQueue how to stop waiting on objects on Windows

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has canceled Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 42826: Potential crash in thread pool because WorkQueue keeps waiting on
closed HANDLEs
https://bugs.webkit.org/show_bug.cgi?id=42826

Attachment 65752: Teach WorkQueue how to stop waiting on objects on Windows
https://bugs.webkit.org/attachment.cgi?id=65752&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
This patch introduces a crash due to WorkItemWin being destroyed when it is
currently being used in handleCallback.

To fix this we shouldn't destroy the WorkItemWin until we've unregistered the
wait.