[webkit-reviews] review canceled: [Bug 44788] Implement HTML5-compliant doctype switching : [Attachment 65754] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has canceled Darin Adler <darin at apple.com>'s
request for review:
Bug 44788: Implement HTML5-compliant doctype switching
https://bugs.webkit.org/show_bug.cgi?id=44788

Attachment 65754: Patch
https://bugs.webkit.org/attachment.cgi?id=65754&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/dom/Document.cpp:592
 +	    // All user stylesheets have to reparse using the different mode.
You mentioned that the renderers have to update too (over irc).  Or is that no
longer the case?

WebCore/dom/Document.h:586
 +	bool inNoQuirksMode() const { return m_compatibilityMode ==
NoQuirksMode; }
The new names are much better. :)

WebCore/html/HTMLDocument.cpp:359
 +	    || docType->publicId().startsWith("-//AdvaSoft Ltd//DTD HTML 3.0
asWedit + extensions//", false)
I agree with simon. :)	This seems to want a helper function. :)

WebCore/html/HTMLTreeBuilder.cpp:434
 +     
m_dummyDocumentForFragmentParsing->setCompatibilityMode(fragment->document()->c
ompatibilityMode());
Do we have tests for this?

I retract my earlier comments.	I lept to judgement.

Fantastic patch.  Thanks again.