[webkit-reviews] review granted: [Bug 42862] WebGL in CSS Canvas crashes : [Attachment 65764] Patch with test cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 27 14:06:05 PDT 2010


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 42862: WebGL in CSS Canvas crashes
https://bugs.webkit.org/show_bug.cgi?id=42862

Attachment 65764: Patch with test cases
https://bugs.webkit.org/attachment.cgi?id=65764&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================

> +	   * html/HTMLCanvasElement.cpp:
> +	   (WebCore::HTMLCanvasElement::copiedImage): Add logic to get image
from WebGL so it works with Hyatt's new ImageBuffer logic

This comment will not make any sense in a few months. Be more specific about
what hyatt's changes were.

Also, why didn't we see any other test bustage because of this? What would we
have had to test to see breakage: drawing a 3d canvas into a 2d canvas?


More information about the webkit-reviews mailing list