[webkit-reviews] review requested: [Bug 44788] Implement HTML5-compliant doctype switching : [Attachment 65754] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has asked  for review:
Bug 44788: Implement HTML5-compliant doctype switching
https://bugs.webkit.org/show_bug.cgi?id=44788

Attachment 65754: Patch
https://bugs.webkit.org/attachment.cgi?id=65754&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> @@ -1394,6 +1404,7 @@ void Document::unscheduleStyleRecalc()
>	   documentsThatNeedStyleRecalc->remove(this);
>  
>      m_styleRecalcTimer.stop();
> +    m_pendingStyleRecalcShouldForce = false;
>  }
>  
>  void Document::styleRecalcTimerFired(Timer<Document>*)
> @@ -1431,6 +1442,9 @@ void Document::recalcStyle(StyleChange c
>      ASSERT(!renderer() || renderArena());
>      if (!renderer() || !renderArena())
>	   goto bail_out;
> +    
> +    if (m_pendingStyleRecalcShouldForce)
> +	   change = Force;
>  
>      if (change == Force) {
>	   // style selector may set this again during recalc
> @@ -1488,9 +1502,7 @@ void Document::updateStyleIfNeeded()
>      if (m_frame)
>	   m_frame->animation()->beginAnimationUpdate();
>	   
> -    recalcStyle(m_pendingStyleRecalcShouldForce ? Force : NoChange);
> -    
> -    m_pendingStyleRecalcShouldForce = false;
> +    recalcStyle(NoChange);
>  
>      // Tell the animation controller that updateStyleIfNeeded is finished
and it can do any post-processing
>      if (m_frame)

These changes seem good, but separate from the doctype changes. Can you land
them separately? Can you test them?