[webkit-reviews] review granted: [Bug 44788] Implement HTML5-compliant doctype switching : [Attachment 65754] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 44788: Implement HTML5-compliant doctype switching
https://bugs.webkit.org/show_bug.cgi?id=44788

Attachment 65754: Patch
https://bugs.webkit.org/attachment.cgi?id=65754&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> +    // Check for Quirks Mode.
> +    if (docType->name() != "html"
> +	   || docType->publicId().startsWith("+//Silmaril//dtd html Pro v0r11
19970101//", false)
> +	   || docType->publicId().startsWith("-//AdvaSoft Ltd//DTD HTML 3.0
asWedit + extensions//", false)
> +	   || docType->publicId().startsWith("-//AS//DTD HTML 3.0 asWedit +
extensions//", false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML 2.0 Level 1//",
false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML 2.0 Level 2//",
false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML 2.0 Strict
Level 1//", false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML 2.0 Strict
Level 2//", false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML 2.0 Strict//",
false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML 2.0//", false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML 2.1E//", false)

> +	   || docType->publicId().startsWith("-//IETF//DTD HTML 3.0//", false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML 3.2 Final//",
false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML 3.2//", false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML 3//", false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML Level 0//",
false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML Level 1//",
false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML Level 2//",
false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML Level 3//",
false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML Strict Level
0//", false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML Strict Level
1//", false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML Strict Level
2//", false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML Strict Level
3//", false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML Strict//",
false)
> +	   || docType->publicId().startsWith("-//IETF//DTD HTML//", false)
> +	   || docType->publicId().startsWith("-//Metrius//DTD Metrius
Presentational//", false)
> +	   || docType->publicId().startsWith("-//Microsoft//DTD Internet
Explorer 2.0 HTML Strict//", false)
> +	   || docType->publicId().startsWith("-//Microsoft//DTD Internet
Explorer 2.0 HTML//", false)
> +	   || docType->publicId().startsWith("-//Microsoft//DTD Internet
Explorer 2.0 Tables//", false)
> +	   || docType->publicId().startsWith("-//Microsoft//DTD Internet
Explorer 3.0 HTML Strict//", false)
> +	   || docType->publicId().startsWith("-//Microsoft//DTD Internet
Explorer 3.0 HTML//", false)
> +	   || docType->publicId().startsWith("-//Microsoft//DTD Internet
Explorer 3.0 Tables//", false)
> +	   || docType->publicId().startsWith("-//Netscape Comm. Corp.//DTD
HTML//", false)
> +	   || docType->publicId().startsWith("-//Netscape Comm. Corp.//DTD
Strict HTML//", false)
> +	   || docType->publicId().startsWith("-//O'Reilly and Associates//DTD
HTML 2.0//", false)
> +	   || docType->publicId().startsWith("-//O'Reilly and Associates//DTD
HTML Extended 1.0//", false)
> +	   || docType->publicId().startsWith("-//O'Reilly and Associates//DTD
HTML Extended Relaxed 1.0//", false)
> +	   || docType->publicId().startsWith("-//SoftQuad Software//DTD
HoTMetaL PRO 6.0::19990601::extensions to HTML 4.0//", false)
> +	   || docType->publicId().startsWith("-//SoftQuad//DTD HoTMetaL PRO
4.0::19971010::extensions to HTML 4.0//", false)
> +	   || docType->publicId().startsWith("-//Spyglass//DTD HTML 2.0
Extended//", false)
> +	   || docType->publicId().startsWith("-//SQ//DTD HTML 2.0 HoTMetaL +
extensions//", false)
> +	   || docType->publicId().startsWith("-//Sun Microsystems Corp.//DTD
HotJava HTML//", false)
> +	   || docType->publicId().startsWith("-//Sun Microsystems Corp.//DTD
HotJava Strict HTML//", false)
> +	   || docType->publicId().startsWith("-//W3C//DTD HTML 3 1995-03-24//",
false)
> +	   || docType->publicId().startsWith("-//W3C//DTD HTML 3.2 Draft//",
false)
> +	   || docType->publicId().startsWith("-//W3C//DTD HTML 3.2 Final//",
false)
> +	   || docType->publicId().startsWith("-//W3C//DTD HTML 3.2//", false)
> +	   || docType->publicId().startsWith("-//W3C//DTD HTML 3.2S Draft//",
false)
> +	   || docType->publicId().startsWith("-//W3C//DTD HTML 4.0 Frameset//",
false)
> +	   || docType->publicId().startsWith("-//W3C//DTD HTML 4.0
Transitional//", false)
> +	   || docType->publicId().startsWith("-//W3C//DTD HTML Experimental
19960712//", false)
> +	   || docType->publicId().startsWith("-//W3C//DTD HTML Experimental
970421//", false)
> +	   || docType->publicId().startsWith("-//W3C//DTD W3 HTML//", false)
> +	   || docType->publicId().startsWith("-//W3O//DTD W3 HTML 3.0//",
false)
> +	   || equalIgnoringCase(docType->publicId(), "-//W3O//DTD W3 HTML
Strict 3.0//EN//")
> +	   || docType->publicId().startsWith("-//WebTechs//DTD Mozilla HTML
2.0//", false)
> +	   || docType->publicId().startsWith("-//WebTechs//DTD Mozilla HTML//",
false)
> +	   || equalIgnoringCase(docType->publicId(), "-/W3C/DTD HTML 4.0
Transitional/EN")
> +	   || equalIgnoringCase(docType->publicId(), "HTML")
> +	   || equalIgnoringCase(docType->systemId(),
"http://www.ibm.com/data/dtd/v11/ibmxhtml1-transitional.dtd")
> +	   || (docType->systemId().isEmpty() &&
docType->publicId().startsWith("-//W3C//DTD HTML 4.01 Frameset//", false))
> +	   || (docType->systemId().isEmpty() &&
docType->publicId().startsWith("-//W3C//DTD HTML 4.01 Transitional//", false)))
{
> +	   setCompatibilityMode(QuirksMode);
> +	   return;

Ick.Can we at least pull docType->publicId() into a local variable?