[webkit-reviews] review granted: [Bug 43099] Add JavaScript API to allow a page to go fullscreen : [Attachment 65593] Part 6: FullScreen-WebKit

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 43099: Add JavaScript API to allow a page to go fullscreen
https://bugs.webkit.org/show_bug.cgi?id=43099

Attachment 65593: Part 6: FullScreen-WebKit
https://bugs.webkit.org/attachment.cgi?id=65593&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
> Index: WebKit/WebKit.xcodeproj/project.pbxproj
> ===================================================================
> --- WebKit/WebKit.xcodeproj/project.pbxproj	(revision 65463)
> +++ WebKit/WebKit.xcodeproj/project.pbxproj	(working copy)
> @@ -1623,7 +1623,6 @@
>			isa = PBXProject;
>			buildConfigurationList = 149C283208902B0F008A9EFC /*
Build configuration list for PBXProject "WebKit" */;
>			compatibilityVersion = "Xcode 2.4";
> -			developmentRegion = English;
>			hasScannedForEncodings = 1;
>			knownRegions = (
>				English,

Don't need this change.


> Index: WebKit/mac/WebCoreSupport/WebSystemInterface.mm
> ===================================================================
> --- WebKit/mac/WebCoreSupport/WebSystemInterface.mm	(revision 65463)
> +++ WebKit/mac/WebCoreSupport/WebSystemInterface.mm	(working copy)
> @@ -84,6 +84,7 @@ void InitWebCoreSystemInterface(void)
>      INIT(SignalCFReadStreamHasBytes);
>      INIT(QTIncludeOnlyModernMediaFileTypes);
>      INIT(QTMovieDataRate);
> +    INIT(QTMovieDisableComponent);
>      INIT(QTMovieMaxTimeLoaded);
>      INIT(QTMovieMaxTimeLoadedChangeNotification);
>      INIT(QTMovieMaxTimeSeekable);

This is unrelated to this patch.

r=me with the unrelated changes removed.