[webkit-reviews] review granted: [Bug 36734] Implement symbolic CSS3 list-style-types : [Attachment 65675] Patch with test case

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 36734: Implement symbolic CSS3 list-style-types
https://bugs.webkit.org/show_bug.cgi?id=36734

Attachment 65675: Patch with test case
https://bugs.webkit.org/attachment.cgi?id=65675&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -static inline String toAlphabeticOrNumeric(int number, const UChar*
sequence, int sequenceSize, SequenceType type)
> +static inline String toSequence(int number, const UChar* sequence, unsigned
sequenceSize, SequenceType type)

The code for SymbolicSequence seems to share almost nothing with the alphabetic
and numeric sequences. The assertion needed is different, the buffer size
needed is different, the loop is different. About the only thing that's shared
is the code to subtract one from the passed-in number.

I suggest implementing toSymbolic without calling toAlphabeticOrNumeric.
There's no meaningful code sharing here.

Everything else looks fine.

r=me