[webkit-reviews] review granted: [Bug 43779] RenderImage::imageChanged invalidates wrong area : [Attachment 65714] Patch #1o (add RenderImageResource)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 27 07:37:03 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 43779: RenderImage::imageChanged invalidates wrong area
https://bugs.webkit.org/show_bug.cgi?id=43779

Attachment 65714: Patch #1o (add RenderImageResource)
https://bugs.webkit.org/attachment.cgi?id=65714&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
As discussed on IRC, this approach is fine. The only drawback is the addition
of one additional pointer, compared to the old solution -- but I think it's
acceptable, given the higher level of abstraction it gives us.
Note: I ran all tests on Leopard locally, and it works just fine.

Landing for paroga.


More information about the webkit-reviews mailing list