[webkit-reviews] review denied: [Bug 44679] Web Inspector: provide more information to front-end when breaking on DOM event : [Attachment 65707] Proposed patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 27 06:46:24 PDT 2010
Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 44679: Web Inspector: provide more information to front-end when breaking
on DOM event
https://bugs.webkit.org/show_bug.cgi?id=44679
Attachment 65707: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=65707&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/dom/ContainerNode.cpp:137
+ InspectorController::willInsertDOMNode(this);
Passing child would look more consistent.
WebCore/inspector/InspectorController.h:387
+ if (Page* page = node->document()->page()) {
Please replace nested ifs with guard expressions when nesting is that big.
WebCore/inspector/InspectorController.h:416
+ if (Page* page = node->document()->page()) {
ditto
More information about the webkit-reviews
mailing list