[webkit-reviews] review granted: [Bug 29847] [Qt] Add support for automatically creating new windows in QWebView : [Attachment 65701] patch v2 - addressed simon's review

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 29847: [Qt] Add support for automatically creating new windows in QWebView
https://bugs.webkit.org/show_bug.cgi?id=29847

Attachment 65701: patch v2 - addressed simon's review
https://bugs.webkit.org/attachment.cgi?id=65701&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
WebKit/qt/Api/qwebview.cpp:960
 +	\sa QWebPage::createWindow(),
QWebSettings::setJavaScriptCanOpenWindowsAutomatically()
There's one left :)

Please fix before landing, otherwise r=me :)