[webkit-reviews] review requested: [Bug 34639] Object.defineProperty accepts wrong descriptor : [Attachment 65685] objectdescriptor.diff
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 27 00:50:42 PDT 2010
Xan Lopez <xan.lopez at gmail.com> has asked for review:
Bug 34639: Object.defineProperty accepts wrong descriptor
https://bugs.webkit.org/show_bug.cgi?id=34639
Attachment 65685: objectdescriptor.diff
https://bugs.webkit.org/attachment.cgi?id=65685&action=review
------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
OK, so I think this change might make sense to be done at this level instead of
hardcoding it in toPropertyDescriptor. It changes the result of two tests; one
is essentially the one the reporter submitted, and the other just makes
getOwnProperty descriptor be undefined if the getter is undefined. With this we
match Chrome in both behaviors.
More information about the webkit-reviews
mailing list