[webkit-reviews] review requested: [Bug 44508] [EFL] Add PlatformVideoWindowEfl.cpp for WebKit EFL : [Attachment 65682] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 26 23:58:49 PDT 2010


Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked  for review:
Bug 44508: [EFL] Add PlatformVideoWindowEfl.cpp for WebKit EFL
https://bugs.webkit.org/show_bug.cgi?id=44508

Attachment 65682: Patch
https://bugs.webkit.org/attachment.cgi?id=65682&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
Thanks, I fix this patch according to your comment.
I move the "#include <gtk/gtk.h>" to PlatformVideoWindowGtk.cpp.

BTW, I add the PlatformVideoWindowEfl.cpp to CMakeListEfl.txt in Bug 44098.
(Bug 44098 is blocked by this bug.)
Because, I want to add this file together with other files regarding gstreamer.
So, the PlatformVideoWindowEfl.cpp will be added after landing this patch.


More information about the webkit-reviews mailing list