[webkit-reviews] review denied: [Bug 29847] [Qt] Add support for automatically creating new windows in QWebView : [Attachment 65678] patch v1 - fix the documentation

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 29847: [Qt] Add support for automatically creating new windows in QWebView
https://bugs.webkit.org/show_bug.cgi?id=29847

Attachment 65678: patch v1 - fix the documentation
https://bugs.webkit.org/attachment.cgi?id=65678&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I'm okay with that, please make this bug block the release bugs.

However there's a typo in this patch:
QWebSettings::setJavaScriptCanOpenWindowsAutomatically doesn't exist and should
be setAttribute(...) :)